From 38ef36d998284095c81d8028a51c9c8fd29b9acc Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Fri, 22 Nov 2013 18:37:43 +0100 Subject: child: Fix CID 1130966 - unchecked return value from library check the return code of fcntl via socket_nonblocking on the listen sockets in child_main() Found by coverity. Signed-off-by: Michael Adam --- src/child.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/child.c b/src/child.c index 01ef178..e7e4b35 100644 --- a/src/child.c +++ b/src/child.c @@ -211,7 +211,14 @@ static void child_main (struct child_s *ptr) for (i = 0; i < vector_length(listen_fds); i++) { int *fd = (int *) vector_getentry(listen_fds, i, NULL); - socket_nonblocking(*fd); + ret = socket_nonblocking(*fd); + if (ret != 0) { + log_message(LOG_ERR, "Failed to set the listening " + "socket %d to non-blocking: %s", + fd, strerror(errno)); + exit(1); + } + FD_SET(*fd, &rfds); maxfd = max(maxfd, *fd); } -- cgit v1.2.3