From e07c363df24f5631477f895713728c31ddfd3d43 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox@samba.org>
Date: Fri, 22 Nov 2013 21:44:12 +0100
Subject: reqs: Fix CID 1130969 (part 2) - unchecked return value from library.
Check the return value of socket_blocking (fcntl) at the
end of relay_connection().
Signed-off-by: Michael Adam <obnox@samba.org>
---
src/reqs.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/reqs.c b/src/reqs.c
index a140f5c..439d0e1 100644
--- a/src/reqs.c
+++ b/src/reqs.c
@@ -1220,7 +1220,14 @@ static void relay_connection (struct conn_s *connptr)
/*
* Try to send any remaining data to the server if we can.
*/
- socket_blocking (connptr->server_fd);
+ ret = socket_blocking (connptr->server_fd);
+ if (ret != 0) {
+ log_message(LOG_ERR,
+ "Failed to set server socket to blocking: %s",
+ strerror(errno));
+ return;
+ }
+
while (buffer_size (connptr->cbuffer) > 0) {
if (write_buffer (connptr->server_fd, connptr->cbuffer) < 0)
break;
--
cgit v1.2.3