From df6e8ae0469c5f31632d829eac6da16f54580dc6 Mon Sep 17 00:00:00 2001 From: Mukund Sivaraman Date: Mon, 21 Sep 2009 10:04:09 +0530 Subject: Fix warning about format string not being a string literal --- src/stats.c | 57 +++++++++++++++++++++++++++++---------------------------- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/src/stats.c b/src/stats.c index a614da1..0b60071 100644 --- a/src/stats.c +++ b/src/stats.c @@ -58,27 +58,9 @@ void init_stats (void) /* * Display the statics of the tinyproxy server. */ -int showstats (struct conn_s *connptr) +int +showstats (struct conn_s *connptr) { - static const char *msg = - "\n" - "\n" - "\n" - "%s version %s run-time statistics\n" - "\n" - "

%s version %s run-time statistics

\n" - "

\n" - "Number of open connections: %lu
\n" - "Number of requests: %lu
\n" - "Number of bad connections: %lu
\n" - "Number of denied connections: %lu
\n" - "Number of refused connections due to high load: %lu\n" - "

\n" - "

Generated by %s version %s.

\n" "\n" - "\n"; - char *message_buffer; char opens[16], reqs[16], badconns[16], denied[16], refused[16]; FILE *statfile; @@ -94,14 +76,33 @@ int showstats (struct conn_s *connptr) if (!message_buffer) return -1; - snprintf (message_buffer, MAXBUFFSIZE, msg, - PACKAGE, VERSION, PACKAGE, VERSION, - stats->num_open, - stats->num_reqs, - stats->num_badcons, stats->num_denied, - stats->num_refused, PACKAGE, VERSION); - - if (send_http_message (connptr, 200, "OK", message_buffer) < 0) { + snprintf + (message_buffer, MAXBUFFSIZE, + "\n" + "\n" + "\n" + "%s version %s run-time statistics\n" + "\n" + "

%s version %s run-time statistics

\n" + "

\n" + "Number of open connections: %lu
\n" + "Number of requests: %lu
\n" + "Number of bad connections: %lu
\n" + "Number of denied connections: %lu
\n" + "Number of refused connections due to high load: %lu\n" + "

\n" + "

Generated by %s version %s.

\n" "\n" + "\n", + PACKAGE, VERSION, PACKAGE, VERSION, + stats->num_open, + stats->num_reqs, + stats->num_badcons, stats->num_denied, + stats->num_refused, PACKAGE, VERSION); + + if (send_http_message (connptr, 200, "OK", + message_buffer) < 0) { safefree (message_buffer); return -1; } -- cgit v1.2.3