From 0a998034253ccd7239777fa362a830b46b6630c6 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox@samba.org>
Date: Fri, 22 Nov 2013 18:30:30 +0100
Subject: reqs: Fix CID 1130967 - unchecked return value from library.
Check the return code of fcntl via socket_blocking
in pull_client_data().
Found by coverity.
Signed-off-by: Michael Adam <obnox@samba.org>
---
src/reqs.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/reqs.c b/src/reqs.c
index fcf1f09..f828065 100644
--- a/src/reqs.c
+++ b/src/reqs.c
@@ -534,7 +534,13 @@ static int pull_client_data (struct conn_s *connptr, long int length)
}
len = recv (connptr->client_fd, buffer, 2, MSG_PEEK);
- socket_blocking (connptr->client_fd);
+
+ ret = socket_blocking (connptr->client_fd);
+ if (ret != 0) {
+ log_message(LOG_ERR, "Failed to set the client socket "
+ "to blocking: %s", strerror(errno));
+ goto ERROR_EXIT;
+ }
if (len < 0 && errno != EAGAIN)
goto ERROR_EXIT;
--
cgit v1.2.3