diff options
| author | Mukund Sivaraman <muks@banu.com> | 2009-09-21 10:04:09 +0530 |
|---|---|---|
| committer | Mukund Sivaraman <muks@banu.com> | 2009-09-21 10:04:09 +0530 |
| commit | df6e8ae0469c5f31632d829eac6da16f54580dc6 (patch) | |
| tree | 9dc5e1580a6a7f00b89fd5ff2f292055a1094305 /src | |
| parent | f0cc213c5a50f43ac59ae91d427ce093df65bb09 (diff) | |
| download | tinyproxy-df6e8ae0469c5f31632d829eac6da16f54580dc6.tar.gz tinyproxy-df6e8ae0469c5f31632d829eac6da16f54580dc6.zip | |
Fix warning about format string not being a string literal
Diffstat (limited to 'src')
| -rw-r--r-- | src/stats.c | 57 |
1 files changed, 29 insertions, 28 deletions
diff --git a/src/stats.c b/src/stats.c index a614da1..0b60071 100644 --- a/src/stats.c +++ b/src/stats.c @@ -58,27 +58,9 @@ void init_stats (void) /* * Display the statics of the tinyproxy server. */ -int showstats (struct conn_s *connptr) +int +showstats (struct conn_s *connptr) { - static const char *msg = - "<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n" - "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\" " - "\"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">\n" - "<html>\n" - "<head><title>%s version %s run-time statistics</title></head>\n" - "<body>\n" - "<h1>%s version %s run-time statistics</h1>\n" - "<p>\n" - "Number of open connections: %lu<br />\n" - "Number of requests: %lu<br />\n" - "Number of bad connections: %lu<br />\n" - "Number of denied connections: %lu<br />\n" - "Number of refused connections due to high load: %lu\n" - "</p>\n" - "<hr />\n" - "<p><em>Generated by %s version %s.</em></p>\n" "</body>\n" - "</html>\n"; - char *message_buffer; char opens[16], reqs[16], badconns[16], denied[16], refused[16]; FILE *statfile; @@ -94,14 +76,33 @@ int showstats (struct conn_s *connptr) if (!message_buffer) return -1; - snprintf (message_buffer, MAXBUFFSIZE, msg, - PACKAGE, VERSION, PACKAGE, VERSION, - stats->num_open, - stats->num_reqs, - stats->num_badcons, stats->num_denied, - stats->num_refused, PACKAGE, VERSION); - - if (send_http_message (connptr, 200, "OK", message_buffer) < 0) { + snprintf + (message_buffer, MAXBUFFSIZE, + "<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n" + "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\" " + "\"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">\n" + "<html>\n" + "<head><title>%s version %s run-time statistics</title></head>\n" + "<body>\n" + "<h1>%s version %s run-time statistics</h1>\n" + "<p>\n" + "Number of open connections: %lu<br />\n" + "Number of requests: %lu<br />\n" + "Number of bad connections: %lu<br />\n" + "Number of denied connections: %lu<br />\n" + "Number of refused connections due to high load: %lu\n" + "</p>\n" + "<hr />\n" + "<p><em>Generated by %s version %s.</em></p>\n" "</body>\n" + "</html>\n", + PACKAGE, VERSION, PACKAGE, VERSION, + stats->num_open, + stats->num_reqs, + stats->num_badcons, stats->num_denied, + stats->num_refused, PACKAGE, VERSION); + + if (send_http_message (connptr, 200, "OK", + message_buffer) < 0) { safefree (message_buffer); return -1; } |