From 2004abc1e33f5c59365f7494f3a288b4dc8beb62 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Fri, 22 Nov 2013 17:28:33 +0100 Subject: reqs: fix CID 1130970 - unchecked return code from library Effectively, the return code of fcntl was not checked by not checking the return code of socket_nonblocking() for the client fd. Found by coverity. Signed-off-by: Michael Adam --- src/reqs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/reqs.c') diff --git a/src/reqs.c b/src/reqs.c index d7f5438..00e20aa 100644 --- a/src/reqs.c +++ b/src/reqs.c @@ -1119,7 +1119,13 @@ static void relay_connection (struct conn_s *connptr) int maxfd = max (connptr->client_fd, connptr->server_fd) + 1; ssize_t bytes_received; - socket_nonblocking (connptr->client_fd); + ret = socket_nonblocking (connptr->client_fd); + if (ret != 0) { + log_message(LOG_ERR, "Failed to set the client socket " + "to non-blocking: %s", strerror(errno)); + return; + } + socket_nonblocking (connptr->server_fd); last_access = time (NULL); -- cgit v1.2.3